Function contains unused argument PYL-W0613
Anti-pattern
Major
20 days ago
—
4 years old
Unused argument 'parent'
985 })
986
987 def create_list_resolver(Model, mapper):
988 def resolver(parent, info, filters=None, lookups=None, sort=None, pagination=None, search=None): 989 request = info.context.get('request')
990
991 if before_resolve is not None:Unused argument 'with_relations'
718 self.model_filters_field_types[cls_name] = cls
719 return cls
720
721 def get_model_relationship_filters_type(self, MappedBase, mapper, relationship, with_relations, depth=1): 722 table_name = get_table_name(MappedBase.metadata, mapper.selectable)
723 model_name = clean_name(table_name)
724 relationship_key = clean_name(relationship['name'])Unused argument 'queryset'
117 return is_null(queryset, column, value)
118
119
120def coveredby(queryset, column, value):121 return column.ST_CoveredBy(value)
122
123Unused argument 'queryset'
98 return column.astext.ilike('%{}%'.format(value))
99
100
101def is_null(queryset, column, value):102 if value:
103 return column.__eq__(None)
104 else:Unused argument 'queryset'
89 return column.ilike('%{}%'.format(value))
90
91
92def json_icontains(queryset, column, value): 93 field_type = column.property.columns[0].type if hasattr(column, 'property') else column.type
94
95 if is_instance_or_subclass(field_type, (sqltypes.JSON, sqltypes.NullType)) or not hasattr(column, 'astext'):
Description
An unused argument can lead to confusions. It should be removed. If this variable is necessary, name the variable _ or start the name with unused or _unused.
Bad practice
def square(x, y=1):
return x * x
class MySubClass(MyClass):
def __init__(self, number):
self.value = 42 # argument `number` remains unused
Preferred:
def square(x):
return x * x
class MySubClass(MyClass):
def __init__(self, _):
self.value = 42