Avoid square-bracket notation when accessing properties JS-0049
Anti-pattern
a month ago
—
7 months old
["error"] is better written in dot notation.
13 let re = await (await post("/api/changeUsername",{"currentPW":document.getElementById("currentPW").value.toString(),"newUsername":document.getElementById("newUsername").value})).json()
14 document.getElementById("response").innerText = re["error"] || re["success"]
15 document.getElementById("response").style="color:green"
16 if(re["error"]) {17 document.getElementById("response").style="color:red"
18 }
19 document.getElementById("currentPW").value = ""["success"] is better written in dot notation.
11async function change(){
12 if(window.confirm("Are you sure that you want to change your Username?")){
13 let re = await (await post("/api/changeUsername",{"currentPW":document.getElementById("currentPW").value.toString(),"newUsername":document.getElementById("newUsername").value})).json()
14 document.getElementById("response").innerText = re["error"] || re["success"]15 document.getElementById("response").style="color:green"
16 if(re["error"]) {
17 document.getElementById("response").style="color:red"["error"] is better written in dot notation.
11async function change(){
12 if(window.confirm("Are you sure that you want to change your Username?")){
13 let re = await (await post("/api/changeUsername",{"currentPW":document.getElementById("currentPW").value.toString(),"newUsername":document.getElementById("newUsername").value})).json()
14 document.getElementById("response").innerText = re["error"] || re["success"]15 document.getElementById("response").style="color:green"
16 if(re["error"]) {
17 document.getElementById("response").style="color:red"["error"] is better written in dot notation.
2 let user = await (await fetch("/api/getuser")).json()
3 //user["username"],user["error"]
4 if(user["username"])document.getElementById("username").innerText = `Current User: ${user["username"]}`
5 if(user["error"])document.getElementById("username").innerText = `Error: ${user["error"]}` 6
7}
8["error"] is better written in dot notation.
2 let user = await (await fetch("/api/getuser")).json()
3 //user["username"],user["error"]
4 if(user["username"])document.getElementById("username").innerText = `Current User: ${user["username"]}`
5 if(user["error"])document.getElementById("username").innerText = `Error: ${user["error"]}` 6
7}
8
Description
In JavaScript, there are two ways to access the properties of an object:
- dot-notation
(object.property)( Recommended ) - square-bracket notation
(object["property"])( Bad Practice )
The dot notation is preferred because it is easier to read, less verbose, and works better with aggressive JavaScript minimizers.
Bad Practice
const x = object["property"];
Recommended
const x = object.property;
x = object[y];