Types of function parameters can be combined CRT-A0017
Style
Minor
8 months ago
—
2 years old
func(lastId int64, productId int64, field string) string could be replaced with func(lastId, productId int64, field string) string
64 return posts, err
65}
66
67func createPostsQuery(lastId int64, productId int64, field string) string { 68 var query string
69 if field != "" {
70 if lastId == 0 {func(field string, productId int64, lastId int64, preloadUser bool) ([]Post, error) could be replaced with func(field string, productId, lastId int64, preloadUser bool) ([]Post, error)
49 *gorm.DB
50}
51
52func (db *DBConn) GetPosts(field string, productId int64, lastId int64, preloadUser bool) ([]Post, error) { 53 var posts []Post
54 var err error
55 query := createPostsQuery(lastId, productId, field)
Description
If parameters of the same type lie consecutively, mention their type once at the end of the last parameter.
Unlike other languages, like C, where all parameters must be specified with types explicitly, it is not required to do so in Go. Combining the types is usually recommended for the sake of brevity.
Bad practice
func foo(a, b int, c, d int, e, f int, g int) {}
Recommended
func foo(a, b, c, d, e, f, g int) {}