Unused parameter in function RVV-B0012
Bug risk
Minor
7 months ago
—
2 years old
parameter 'tx' seems to be unused, consider removing or renaming it as _
36 p.TSV = tsv
37 return nil
38}
39func (p *Product) BeforeUpdate(tx *gorm.DB) error {40 p.Name = strings.Trim(p.Name, " ")
41 tsv, err := createTSVector(p.Name, p.Description)
42 if err != nil {parameter 'tx' seems to be unused, consider removing or renaming it as _
27 Messages []Message `json:"messages"`
28}
29
30func (p *Product) BeforeCreate(tx *gorm.DB) error {31 p.Name = strings.Trim(p.Name, " ")
32 tsv, err := createTSVector(p.Name, p.Description)
33 if err != nil {parameter 'tx' seems to be unused, consider removing or renaming it as _
133func (p *Post) GetID() uint {
134 return p.ID
135}
136func (c *Comment) BeforeCreate(tx *gorm.DB) error {137 var post Post
138 err := DB.First(&post, c.PostID).Error
139 if errors.Is(err, gorm.ErrRecordNotFound) {parameter 'db' seems to be unused, consider removing or renaming it as _
42 return true
43}
44
45func (p *Post) BeforeCreate(db *gorm.DB) error { 46 if !checkTypes(p.Type) {
47 return errors.New("invalid type")
48 }parameter 'lastId' seems to be unused, consider removing or renaming it as _
149 }
150 return posts, nil
151}
152func (db *DBConn) GetOldestFollowedProductsPost(UserFollowedProducts []Product, field string, lastId uint64) uint {153 var productIds []uint
154 for _, product := range UserFollowedProducts {
155 productIds = append(productIds, product.ID)
Description
Unused parameters in functions or methods should be replaced with _
(underscore) or removed.
Functions or methods with unused parameters can be a symptom of unfinished
refactoring or a bug. If an unused parameter is present, it should be named _
(underscore) to avoid raising this issue and better readability.
Bad practice
func abc(unused string) {
fmt.Println("Not using any passed params.")
}
Recommended
func abc(_ string) {
fmt.Println("Not using any passed params.")
}
func abc() {
fmt.Println("Not using any passed params.")
}