this value of err is never used
19 announcementCount, err := db.DB.ProductFieldPostCount(productIdInt, "announcements", true)
20 underReviewCount, err := db.DB.ProductFieldPostCount(productIdInt, "under-review", false)
21 workingOnCount, err := db.DB.ProductFieldPostCount(productIdInt, "working-on", false)
22 doneCount, err := db.DB.ProductFieldPostCount(productIdInt, "done", false)23 return c.JSON(fiber.Map{
24 "bugs": bugCount,
25 "announcements": announcementCount,this value of err is never used
18 suggestionCount, err := db.DB.ProductFieldPostCount(productIdInt, "suggestions", true)
19 announcementCount, err := db.DB.ProductFieldPostCount(productIdInt, "announcements", true)
20 underReviewCount, err := db.DB.ProductFieldPostCount(productIdInt, "under-review", false)
21 workingOnCount, err := db.DB.ProductFieldPostCount(productIdInt, "working-on", false)22 doneCount, err := db.DB.ProductFieldPostCount(productIdInt, "done", false)
23 return c.JSON(fiber.Map{
24 "bugs": bugCount,this value of err is never used
17 bugCount, err := db.DB.ProductFieldPostCount(productIdInt, "bugs", true)
18 suggestionCount, err := db.DB.ProductFieldPostCount(productIdInt, "suggestions", true)
19 announcementCount, err := db.DB.ProductFieldPostCount(productIdInt, "announcements", true)
20 underReviewCount, err := db.DB.ProductFieldPostCount(productIdInt, "under-review", false)21 workingOnCount, err := db.DB.ProductFieldPostCount(productIdInt, "working-on", false)
22 doneCount, err := db.DB.ProductFieldPostCount(productIdInt, "done", false)
23 return c.JSON(fiber.Map{this value of err is never used
16 }
17 bugCount, err := db.DB.ProductFieldPostCount(productIdInt, "bugs", true)
18 suggestionCount, err := db.DB.ProductFieldPostCount(productIdInt, "suggestions", true)
19 announcementCount, err := db.DB.ProductFieldPostCount(productIdInt, "announcements", true)20 underReviewCount, err := db.DB.ProductFieldPostCount(productIdInt, "under-review", false)
21 workingOnCount, err := db.DB.ProductFieldPostCount(productIdInt, "working-on", false)
22 doneCount, err := db.DB.ProductFieldPostCount(productIdInt, "done", false)this value of err is never used
15 })
16 }
17 bugCount, err := db.DB.ProductFieldPostCount(productIdInt, "bugs", true)
18 suggestionCount, err := db.DB.ProductFieldPostCount(productIdInt, "suggestions", true)19 announcementCount, err := db.DB.ProductFieldPostCount(productIdInt, "announcements", true)
20 underReviewCount, err := db.DB.ProductFieldPostCount(productIdInt, "under-review", false)
21 workingOnCount, err := db.DB.ProductFieldPostCount(productIdInt, "working-on", false)this value of err is never used
14 "error": "product id must be an integer",
15 })
16 }
17 bugCount, err := db.DB.ProductFieldPostCount(productIdInt, "bugs", true)18 suggestionCount, err := db.DB.ProductFieldPostCount(productIdInt, "suggestions", true)
19 announcementCount, err := db.DB.ProductFieldPostCount(productIdInt, "announcements", true)
20 underReviewCount, err := db.DB.ProductFieldPostCount(productIdInt, "under-review", false)this value of err is never used
27 }
28 isOwner := User.ID == product.UserID
29 var Users []ProductUsersInfo
30 rows, err := db.DB.Table("users, product_users").Preload("FollowedProduct").Select("users.id, users.name, product_users.role, users.pfp").Where("product_users.product_id = ? and product_users.user_id = users.id", product.ID).Rows()31 defer func(rows *sql.Rows) {
32 err := rows.Close()
33 if err != nil {this value of err is never used
117 UserID: conn.user.Id,
118 Message: finalMsg.Message,
119 }
120 err = db.DB.Create(&dbMsg).Error121 }
122 if err := publisher.Publish(ctx, "messages", finalMsg).Err(); err != nil {
123 panic(err)
Description
Value has been assigned to a variable, but it is being overwritten before being read. In most cases, this could be a forgotten error check or dead code.
Bad practice
err := Op1()
// error value assigned to "err" by "Op1" is replaced with
// error value assigned by "Op2" before even being read even
// once
err = Op2()
if err != nil {
return err
}
Recommended
// Ignore the error value returned by "Op1"
Op1()
err := Op2()
if err != nil {
return err
}
err := Op1()
// Read the error value assigned to "err" by "Op1"
if err != nil {
return err
}
err = Op2()
if err != nil {
return err
}