Consider having 1
public class per namespace CS-R1035
Anti-pattern
Major
10 days ago
—
19 days old
Multiple public classes declared in a single file
2using System.Collections.Generic;
3using System.Text;
4
5namespace ClassDiagrams 6{ 7 public class Worksheet 8 { 9 }1011 public class CopyOfWorksheet12 {13 }14}Multiple public classes declared in a single file
2using System.Collections.Generic;
3using System.Text;
4
5namespace ClassDiagrams 6{ 7 public class PHPExcel_Writer_Serialized : PHPExcel_Writer_IWriter 8 { 9 #region IWriter Members1011 public PHPExcel writes12 {13 get14 {15 throw new Exception("The method or operation is not implemented.");16 }17 set18 {19 throw new Exception("The method or operation is not implemented.");20 }21 }2223 #endregion24 }2526 public class PHPExcel_Writer_CSV : PHPExcel_Writer_IWriter27 {28 #region IWriter Members2930 public PHPExcel writes31 {32 get33 {34 throw new Exception("The method or operation is not implemented.");35 }36 set37 {38 throw new Exception("The method or operation is not implemented.");39 }40 }4142 #endregion43 }4445 public class PHPExcel_Writer_Excel5 : PHPExcel_Writer_IWriter46 {47 #region IWriter Members4849 public PHPExcel writes50 {51 get52 {53 throw new Exception("The method or operation is not implemented.");54 }55 set56 {57 throw new Exception("The method or operation is not implemented.");58 }59 }6061 #endregion62 }6364 public class PHPExcel_Writer_HTML : PHPExcel_Writer_IWriter65 {66 #region IWriter Members6768 public PHPExcel writes69 {70 get71 {72 throw new Exception("The method or operation is not implemented.");73 }74 set75 {76 throw new Exception("The method or operation is not implemented.");77 }78 }7980 #endregion81 }82}Multiple public classes declared in a single file
2using System.Collections.Generic;
3using System.Text;
4
5namespace ClassDiagrams 6{ 7 public class PHPExcel_Reader_Serialized : PHPExcel_Reader_IReader 8 { 9 #region IReader Members1011 public PHPExcel reads12 {13 get14 {15 throw new Exception("The method or operation is not implemented.");16 }17 set18 {19 throw new Exception("The method or operation is not implemented.");20 }21 }2223 #endregion24 }2526 public class PHPExcel_Reader_CSV : PHPExcel_Reader_IReader27 {28 #region IReader Members2930 public PHPExcel reads31 {32 get33 {34 throw new Exception("The method or operation is not implemented.");35 }36 set37 {38 throw new Exception("The method or operation is not implemented.");39 }40 }4142 #endregion43 }44}Multiple public classes declared in a single file
2using System.Collections.Generic;
3using System.Text;
4
5namespace ClassDiagrams 6{ 7 public class PHPExcel_Reader_Excel5 : PHPExcel_Reader_IReader 8 { 9 #region PHPExcel_Writer_IReader Members1011 public PHPExcel reads12 {13 get14 {15 throw new Exception("The method or operation is not implemented.");16 }17 set18 {19 throw new Exception("The method or operation is not implemented.");20 }21 }2223 #endregion24 }2526 public class PHPExcel_Reader_Excel2003XML : PHPExcel_Reader_IReader27 {28 #region PHPExcel_Writer_IReader Members2930 public PHPExcel reads31 {32 get33 {34 throw new Exception("The method or operation is not implemented.");35 }36 set37 {38 throw new Exception("The method or operation is not implemented.");39 }40 }4142 #endregion43 }4445 public class PHPExcel_Reader_SYLK : PHPExcel_Reader_IReader46 {47 #region PHPExcel_Writer_IReader Members4849 public PHPExcel reads50 {51 get52 {53 throw new Exception("The method or operation is not implemented.");54 }55 set56 {57 throw new Exception("The method or operation is not implemented.");58 }59 }6061 #endregion62 }63}Multiple public classes declared in a single file
2using System.Collections.Generic;
3using System.Text;
4
5namespace ClassDiagrams 6{ 7 public class PHPExcel 8 { 9 /// <remarks></remarks>10 public Worksheet Worksheets11 {12 get13 {14 throw new System.NotImplementedException();15 }16 set17 {18 }19 }20 }2122 public class PHPExcel_Writer_PDF : PHPExcel_Writer_IWriter23 {24 #region PHPExcel_Writer_IWriter Members2526 public PHPExcel writes27 {28 get29 {30 throw new Exception("The method or operation is not implemented.");31 }32 set33 {34 throw new Exception("The method or operation is not implemented.");35 }36 }3738 #endregion39 }40}
Description
Having more than 1 public class per namespace increases the complexity and affects the overall code readability and navigation. It is therefore recommended that you have a single public class per namespace.