Float/Double constructor is inefficient, use valueOf instead JAVA-P0068
Performance
Major
a month ago
—
2 months old
Float constructor is inefficient, use Float.valueOf instead58 case JPEG:
59 transcoder = new JPEGTranscoder();
60 transcoder.addTranscodingHint(JPEGTranscoder.KEY_QUALITY,
61 new Float(0.9));62 break;
63 case PDF:
64 transcoder = new PDFTranscoder();
Description
Using Float or Double's default constructor is guaranteed to always result in a new object whereas the valueOf method of these classes allows the JVM to cache values, which is known as interning.
Using cached values avoids object allocation and the resulting code will be faster. Unless the class must be compatible with JVMs predating Java 1.5, use either autoboxing or the valueOf() method when creating instances of Double and Float.
Bad Practice
Float a = new Float(21.422);
Recommended
Float a = 21.422;
// or
Float a = Float.valueOf(21.422);
Note - This issue will be ignored within tests.
References
- Spotbugs - DM_FP_NUMBER_CTOR