Unused variable SH-2034
Anti-pattern
Major
a month ago
—
2 months old
POP_USER appears unused. Verify use (or export if used externally)
66 ;;
67 USER)
68 if [ -n "${ARGS}" ] ; then
69 POP_USER="${ARGS}" 70 ANSWER="+OK Please send PASS command"
71 fi
72 ;;DEBUG appears unused. Verify use (or export if used externally)
19LOGFILE=${LOGFOLDER}/fakepop.log
20
21LOGGING=1
22DEBUG=1 23TIMEOUT=60
24
25POP_USER=POP_USER appears unused. Verify use (or export if used externally)
66 ;;
67 USER)
68 if [ -n "${ARGS}" ] ; then
69 POP_USER="${ARGS}" 70 ANSWER="+OK Please send PASS command"
71 fi
72 ;;DEBUG appears unused. Verify use (or export if used externally)
19LOGFILE=${LOGFOLDER}/fakepop.log
20
21LOGGING=1
22DEBUG=1 23TIMEOUT=60
24
25POP_USER=
Description
Variables that are declared but not used for anything should be removed.
Problematic code:
foo=42
echo "$FOO"
Preferred code:
foo=42
echo "$foo"
Exceptions:
This warning may be falsely emitted when a variable is referenced indirectly, or it is intentionally not used.
- Indirection: It's the checker's intended behavior to emit this warning for any variable that is only referenced though indirection:
# foo generates a warning, even though it has five indirect references
foo=42
name=foo
echo "${!name} $((name))"
export "$name"; eval "echo $name"
declare -n name; echo "$name"
This is an intentional design decision and not a bug. If you have variables that will not have direct references, consider using an associative array in bash, or ignore this warning.
- Intentionally unused variables:
For throwaway variables, consider using
_as a dummy:
read _ last _ zip _ _ <<< "$str"
echo "$last, $zip"