JS-0050 · Avoid use of `==` and `!=`

Avoid use of == and != JS-0050

Anti-pattern

Minor

a year ago — a year old

Expected '===' and instead saw '=='

 98                try {
 99                    await Model.findOneAndUpdate({_id: data[i]._id}, {used: true}, {new: true})
100                    let response = await web3.eth.sendSignedTransaction('0x' + signedTx.serialize().toString('hex'))
101                    if(response.transactionHash == null) {102                        console.error('trascation not minded')
103                    }
104                    response.hash = response.transactionHash

Expected '===' and instead saw '=='

src/controller/controller.js

238    console.log('log->signedTx', signedTx)
239    try {
240        let response = await web3.eth.sendSignedTransaction('0x' + signedTx.serialize().toString('hex'))
241        if(response.transactionHash == null) {242            res.status(500).json({ message: `Transaction not mined` })
243        }
244        response.hash = response.transactionHash

Expected '===' and instead saw '=='

src/controller/controller.js

182
183                try {
184                    let response = await web3.eth.sendSignedTransaction('0x' + signedTx.serialize().toString('hex'))
185                    if(response.transactionHash == null) {186                        res.status(500).json({ message: `Transaction  not mined` })
187                    }
188                    response.hash = response.transactionHash

Description

It is considered good practice to use the type-safe equality operators === and !== instead of their regular counterparts == and !=.

The strict equality operators (=== and !==) use the strict equality comparison algorithm to compare two operands.

If the operands are of different types, return false.
If both operands are objects, return true only if they refer to the same object.
If both operands are null or both operands are undefined, return true.
If either operand is NaN, return false.
Otherwise, compare the two operand's values:
- Numbers must have the same numeric values. +0 and -0 are considered to be the same value.
- Strings must have the same characters in the same order.
- Booleans must be both true or both false.

The most notable difference between this operator and the equality (==) operator is that if the operands are of different types, the == operator attempts to convert them to the same type before comparing.

Bad Practice

a == b
foo == true
bananas != 1
value == undefined
typeof foo == 'undefined'
'hello' != 'world'
0 == 0
true == true
foo == null

ANocturnalGuy / proxy-api

Bad Practice

Recommended