JS-0128 · Should not have unused variables

Should not have unused variables JS-0128

Bug risk

Major

a year ago — a year old

'express' is assigned a value but never used. Allowed unused vars must match /^_/u

  1// const { jobType } = require('../constants')
  2require('dotenv').config();
  3const cors = require('cors');
  4const express = require('express');  5const mongoose = require('mongoose');
  6const mongoString = process.env.DATABASE_URL;
  7

'contractAddr' is assigned a value but never used. Allowed unused vars must match /^_/u

src/withdraw.js

 10const { Transaction } = require('@ethereumjs/tx')
 11const ContractABI = require('../abis/proxy.json')
 12const TokenABI = require('../abis/ERC20.json')
 13const { contractAddr, privateKey } = require('./config') 14const Model = require('../models/model');
 15const web3 = getWeb3()
 16

'ContractABI' is assigned a value but never used. Allowed unused vars must match /^_/u

src/withdraw.js

  8const getWeb3 = require('./web3')
  9const { Chain, Common, Hardfork } = require('@ethereumjs/common')
 10const { Transaction } = require('@ethereumjs/tx')
 11const ContractABI = require('../abis/proxy.json') 12const TokenABI = require('../abis/ERC20.json')
 13const { contractAddr, privateKey } = require('./config')
 14const Model = require('../models/model');

'cors' is assigned a value but never used. Allowed unused vars must match /^_/u

src/withdraw.js

  1// const { jobType } = require('../constants')
  2require('dotenv').config();
  3const cors = require('cors');  4const express = require('express');
  5const mongoose = require('mongoose');
  6const mongoString = process.env.DATABASE_URL;

'updateData' is defined but never used. Allowed unused vars must match /^_/u

src/controller/controller.js

102    }
103}
104
105async function updateData(res, response, txBlockNumber) {106
107    const currentBlockNumber = await web3.eth.getBlockNumber()
108    const confirmations = currentBlockNumber - txBlockNumber

Description

Found variables that are declared but not used anywhere.

NOTE: In browser applications, DeepSource recommends the use of ESModules over regular text/javascript scripts. Currently, we don't support variables that are not explicitly exported, and are injected into other scripts by being included in an HTML file

Unused variables are most often the result of incomplete refactoring. They can lead to confusing code and minor performance hitches.

NOTE: If you have intentionally left a variable unused, we suggest you to prefix the variable name with a _ to prevent them from being flagged by DeepSource.

Bad Practice

// Write-only variables are not considered as used.
let y = 10;
y = 5;

// A variable that modifies only itself isn't considered used.
let z = 0;
z = z + 1;

// Unused argument
(function(x) {
    return 5;
})();

// Unused recursive functions also raise this issue.
function fact(n) {
    if (n < 2) return 1;
    return n * fact(n - 1);
}

// When a function definition destructures an array,
// unused entries from the array also cause warnings.
function getY([x, y]) {
    return y;
}

let x = 10;
alert(x);

((arg1) => {
    return arg1;
})();

let myFunc;
myFunc = (n) => {
    // this is legal
    if (n < 0) myFunc();
};

// this is also considered legal
console.log(declaredLater);
var declaredLater;

// Only the second argument from the descructured array is used.
function getY([, y]) {
    return y;
}

ANocturnalGuy / proxy-api

Bad Practice

Recommended