Class methods should utilize
this JS-0105
Anti-pattern
Minor
a year ago
—
a year old
Expected 'this' to be used by class async method 'getPreGameDetails'.
25 return data;
26 }
27
28 async getPreGameDetails() { 29 const tokens = await utils.getTokens();
30 if (!tokens) return null;
31 var matchid = await axios.get(`https://glz-eu-1.eu.a.pvp.net/pregame/v1/players/${tokens.subject}`, {headers: {Authorization: "Bearer " + tokens.accessToken,"X-Riot-Entitlements-JWT": tokens.token,"X-Riot-ClientVersion": "release-03.00-shipping-22-574489","X-Riot-ClientPlatform": "ew0KCSJwbGF0Zm9ybVR5cGUiOiAiUEMiLA0KCSJwbGF0Zm9ybU9TIjogIldpbmRvd3MiLA0KCSJwbGF0Zm9ybU9TVmVyc2lvbiI6ICIxMC4wLjE5MDQyLjEuMjU2LjY0Yml0IiwNCgkicGxhdGZvcm1DaGlwc2V0IjogIlVua25vd24iDQp9"}}).catch(error => {return error})Expected 'this' to be used by class async method 'getUserData'.
17 return JSON.parse(data);
18 }
19
20 async getUserData(){ 21 const data = utils.getLocalData();
22
23 if (!data) return null;Expected 'this' to be used by class async method 'getUserDetails'.
8 this.eventHandler();
9 }
10
11 async getUserDetails() { 12 const localData = await utils.getLocalData();
13 if (!localData) return null;
14Expected 'this' to be used by class async method 'getCoreGameDetails'.
43 return pre_game_data.data;
44 };
45
46 async getCoreGameDetails() { 47 const tokens = await utils.getTokens();
48 if (!tokens) return null;
49 var matchid = await axios.get(`https://glz-eu-1.eu.a.pvp.net/core-game/v1/players/${tokens.subject}`, {headers: {Authorization: "Bearer " + tokens.accessToken,"X-Riot-Entitlements-JWT": tokens.token,"X-Riot-ClientVersion": "release-03.00-shipping-22-574489","X-Riot-ClientPlatform": "ew0KCSJwbGF0Zm9ybVR5cGUiOiAiUEMiLA0KCSJwbGF0Zm9ybU9TIjogIldpbmRvd3MiLA0KCSJwbGF0Zm9ybU9TVmVyc2lvbiI6ICIxMC4wLjE5MDQyLjEuMjU2LjY0Yml0IiwNCgkicGxhdGZvcm1DaGlwc2V0IjogIlVua25vd24iDQp9"}}).catch(error => {return error})
Description
If a class method does not use this, it can sometimes be made into a static function. If you do convert the method into a static function, instances of the class that call that particular method have to be converted to a static call as well (MyClass.callStaticMethod())
Bad Practice
class Person {
sayHi() {
const greeting = document.createElement("div");
greeting.innerText = "Hello!";
document.appendChild();
}
}
const person = new Person();
person.sayHi();
Recommended
class Person {
static sayHi() {
const greeting = document.createElement("div");
greeting.innerText = "Hello!";
document.appendChild();
}
}
Person.sayHi();