DeepSource
Dashboard Resources Pricing Discover Directory Log in

Run your first analysis.

Find thousands of code security and quality issues in your codebase, before they end up in production.

Start now

Aronshire / ValoCord

Require template literals instead of string concatenation JS-0246
Anti-pattern
Minor
a year ago — a year old
Unexpected string concatenation.
presence.js
101                let map = this.maps.find(map => map.mapUrl === data.match.map);
102                let agent = await axios.get(`https://valorant-api.com/v1/agents/${data.match.charaterID}`).then(res => res.data.data);
103                this.presence = {
104                    details: translate(this.language, "presence:ingame:details") + "[" + data.match.score.ally + " - " + data.match.score.enemy + ']',105                    state: data.match.mode ? (translate(this.language, `presence:pregame:type:${data.match.mode.toLowerCase()}`) ?? data.match.mode) : "Custom Game",
106                    largeImageKey: map.splash,
107                    largeImageText: map.displayName,
Unexpected string concatenation.
electron/renderer.js
14    language = message?.language
15
16    if (message.valorant?.status) {
17        $('#gameStatus').text(message.valorant.user.game_name + '#'+ message.valorant.user.game_tag);18    } else {
19        $('#gameStatus').text(translate(language, "open_valorant"));
20    }
Unexpected string concatenation.
electron/renderer.js
20    }
21
22    if (message.discord?.status) {
23        $('#discordStatus').text(message.discord.user.username + '#' + message.discord.user.discriminator);24    } else {
25        $('#discordStatus').text(translate(language, "open_discord"));
26    }
Unexpected string concatenation.
client/valorant.js
 36
 37        if (!matchid.data) return null;
 38
 39        var pre_game_data = await axios.get(`https://glz-eu-1.eu.a.pvp.net/pregame/v1/matches/${matchid.data.MatchID}`, {headers: {Authorization: "Bearer " + tokens.accessToken,"X-Riot-Entitlements-JWT": tokens.token,"X-Riot-ClientVersion": "release-03.00-shipping-22-574489","X-Riot-ClientPlatform": "ew0KCSJwbGF0Zm9ybVR5cGUiOiAiUEMiLA0KCSJwbGF0Zm9ybU9TIjogIldpbmRvd3MiLA0KCSJwbGF0Zm9ybU9TVmVyc2lvbiI6ICIxMC4wLjE5MDQyLjEuMjU2LjY0Yml0IiwNCgkicGxhdGZvcm1DaGlwc2V0IjogIlVua25vd24iDQp9"}}).catch(error => {return error}) 40        
 41        if (!pre_game_data.data) return null;
 42
Unexpected string concatenation.
client/valorant.js
 31        var matchid = await axios.get(`https://glz-eu-1.eu.a.pvp.net/pregame/v1/players/${tokens.subject}`, {headers: {Authorization: "Bearer " + tokens.accessToken,"X-Riot-Entitlements-JWT": tokens.token,"X-Riot-ClientVersion": "release-03.00-shipping-22-574489","X-Riot-ClientPlatform": "ew0KCSJwbGF0Zm9ybVR5cGUiOiAiUEMiLA0KCSJwbGF0Zm9ybU9TIjogIldpbmRvd3MiLA0KCSJwbGF0Zm9ybU9TVmVyc2lvbiI6ICIxMC4wLjE5MDQyLjEuMjU2LjY0Yml0IiwNCgkicGxhdGZvcm1DaGlwc2V0IjogIlVua25vd24iDQp9"}}).catch(error => {return error})
 32        if(matchid.response && matchid.response.status == 400) {
 33            tokens = await data()
 34            matchid = await axios.get(`https://glz-${settings.region}-1.${settings.region}.a.pvp.net/pregame/v1/players/${tokens.subject}`, {headers: {Authorization: "Bearer " + tokens.accessToken,"X-Riot-Entitlements-JWT": tokens.token,"X-Riot-ClientVersion": "release-03.00-shipping-22-574489","X-Riot-ClientPlatform": "ew0KCSJwbGF0Zm9ybVR5cGUiOiAiUEMiLA0KCSJwbGF0Zm9ybU9TIjogIldpbmRvd3MiLA0KCSJwbGF0Zm9ybU9TVmVyc2lvbiI6ICIxMC4wLjE5MDQyLjEuMjU2LjY0Yml0IiwNCgkicGxhdGZvcm1DaGlwc2V0IjogIlVua25vd24iDQp9"}}).catch(error => {return error}) 35        }
 36
 37        if (!matchid.data) return null;