PYL-W0622 · Re-definition found for builtin function

Art-em1s / csgoempire.py

Active

Re-definition found for builtin function PYL-W0622

Anti-pattern

Major

a year ago — a year old

Redefining built-in 'filter'

114    def get_active_deposits(self):
115        return self.deposits.get_active_deposits()
116
117    def get_inventory(self, filter: bool = True, force_refresh=False):118        if filter:
119            inventory = self.deposits.get_inventory(force_refresh)
120            return [item for item in inventory if item['tradable'] is True and item['market_value'] > 0]

Description

Defining a local variable or function with the same name as a built-in object makes the built-in object unusable within the current scope and makes the code prone to bugs.

Bad practice

dict = {}  # dict is a Python builtin!
for idx, student in enumerate(students):
    dict[student] = idx

Preferred:

roll_number = {}
for idx, student in enumerate(students):
    roll_number[student] = idx