Redundant error checking RVV-B0005
Style
Major
2 years ago
—
3 years old
redundant if ...; err != nil check, just return error instead.
57 return err
58 }
59
60 if err := initProvider(v); err != nil { 61 return err
62 }
63redundant if ...; err != nil check, just return error instead.
62 if err != nil {
63 return err
64 }
65 if err := initProvider(g); err != nil { 66 return err
67 }
68redundant if ...; err != nil check, just return error instead.
62 if err != nil {
63 return err
64 }
65 if err := initProvider(f); err != nil { 66 return err
67 }
68redundant if ...; err != nil check, just return error instead.
72 return fmt.Errorf("crypto key named '%s' is not declared", a.conf.PublicKey)
73 }
74
75 if err := initProvider(a); err != nil { 76 return err
77 }
78
Description
Some simple error checking patterns can be reduced to just a single return
statement returning a variable of type Error.
Bad practice
if err != nil {
return err
}
return nil
Recommended
return err