Unused parameter in function RVV-B0012
Bug risk
Minor
2 years ago
—
2 years old
parameter 'p' seems to be unused, consider removing or renaming it as _
50}
51
52// createServer initializes router and creates routes for each application
53func createServer(p *project, r *router) *fiber.App { 54 fiberApp := fiber.New(fiber.Config{DisableStartupMessage: true})
55 fiberApp.Use(cors.New())
56 fiberApp.Use(logger.New())parameter 'app' seems to be unused, consider removing or renaming it as _
94 return nil, paths
95}
96
97func assembleOAS3Operation(app *app, meta Metadata, OAS3Parameters openapi3.Parameters, OAS3RequestBody *openapi3.RequestBody, successResp *openapi3.Response) *openapi3.Operation { 98 displayName := meta.DisplayName
99 // todo: optimize it and do not call every time
100 unauthorisedDescription := "Could not authenticate with " + displayNameparameter 'app' seems to be unused, consider removing or renaming it as _
94 return token, nil
95}
96
97func invalidateJWT(app *app, token jwt.Token) error { 98 if time.Now().Before(token.Expiration()) {
99 return nil
100 }
Description
Unused parameters in functions or methods should be replaced with _
(underscore) or removed.
Functions or methods with unused parameters can be a symptom of unfinished
refactoring or a bug. If an unused parameter is present, it should be named _
(underscore) to avoid raising this issue and better readability.
Bad practice
func abc(unused string) {
fmt.Println("Not using any passed params.")
}
Recommended
func abc(_ string) {
fmt.Println("Not using any passed params.")
}
func abc() {
fmt.Println("Not using any passed params.")
}