Inefficient use of
toArray with non-zero sized array argument JAVA-P0335
Performance
Major
2 years ago
—
2 years old
result is less efficient than using a zero sized array here
27 weapon_trades.add(new TradeOffers.ProcessItemFactory(Items.EMERALD, 3, DoomItems.ENERGY_CELLS, 6, 12, 5));
28 weapon_trades.add(new TradeOffers.ProcessItemFactory(Items.EMERALD, 3, DoomItems.UNMAKRY_BOLT, 6, 12, 5));
29 TradeOffers.PROFESSION_TO_LEVELED_TRADE.get(VillagerProfession.WEAPONSMITH).put(3,
30 weapon_trades.toArray(result));31 }
32
33 if (DoomConfig.enable_toolsmith_trades) {result is less efficient than using a zero sized array here
73 block_trades.add(new TradeOffers.ProcessItemFactory(Items.EMERALD, 2, DoomBlocks.E1M1_25.asItem(), 1, 12, 5));
74 block_trades.add(new TradeOffers.ProcessItemFactory(Items.EMERALD, 2, DoomBlocks.E1M1_26.asItem(), 1, 12, 5));
75 TradeOffers.PROFESSION_TO_LEVELED_TRADE.get(VillagerProfession.MASON).put(3,
76 block_trades.toArray(result));77 }
78 }
79}result is less efficient than using a zero sized array here
39 tool_trades.add(new TradeOffers.ProcessItemFactory(Items.EMERALD, 2, DoomItems.ARGENT_HOE, 1, 12, 5));
40 tool_trades.add(new TradeOffers.ProcessItemFactory(Items.EMERALD, 2, DoomItems.ARGENT_SHOVEL, 1, 12, 5));
41 TradeOffers.PROFESSION_TO_LEVELED_TRADE.get(VillagerProfession.TOOLSMITH).put(3,
42 tool_trades.toArray(result));43 }
44
45 if (DoomConfig.enable_mason_trades) {
Description
This method uses toArray with a non-zero sized array argument. This is less efficient than passing a zero-sized array.
This method invokes toArray on a Collection object, and passes in an array with a size greater than zero as an argument. It used to be that this was faster than providing an array of size zero (new Type[0]) in older versions of Java prior to 6. This is because the cost of performing reflection operations was quite high in old Java versions.
This is no longer the case, and providing a zero sized array is now just as fast (or even faster) than providing an array of the same size as the original collection. It is now generally better to use a zero-length array as the argument to toArray.
Bad Practice
List<Integer> list = Arrays.asList(1, 2, 3, 4, 5, 6, 7, 8, 9, 10);
Integer[] arr1 = list.toArray(new Integer[list.size()]); // Inefficient
Recommended
Integer[] arr2 = list.toArray(new Integer[0]); // Better