if statements can be merged PTC-W0048
Anti-pattern
Major
5 months ago
—
2 years old
Consider merging collapsible if statements
506 if not ctx.author.voice or not ctx.author.voice.channel:
507 raise commands.CommandError("You are not connected to any voice channel.")
508
509 if ctx.voice_client:510 if ctx.voice_client.channel != ctx.author.voice.channel:
511 raise commands.CommandError("Bot is already in a voice channel.")
512
Description
Nested if statements can be collapsed into a single if statement by separating their condition using and operator.
Merging collapsible if statements increases the code's readability.
Bad practice
if condition1:
if condition2:
dosomething()
Preferred
if condition1 and condition2:
dosomething()
Exception:
DeepSource will not raise this issue when the nested if statements have comments in between them, as it could be explaining why the nested if is in place.