Exception might be lost PYL-W0150
Bug risk
Major
a month ago
—
a year old
return statement in finally block may swallow exception
73 except discord.HTTPException:
74 pass
75 finally:
76 return 77
78 if gen_data.defaultRole:
79 default_role = member.guild.get_role(int(gen_data.defaultRole))return statement in finally block may swallow exception
54 except discord.HTTPException:
55 pass
56 finally:
57 return 58
59 count = len(gen_data.openChannels) if gen_data.openChannels else 0
60 editable = VoiceGeneratorOption.EDITABLE in gen_data.defaultOptions
Description
The finally block may swallow any exceptions raised in the try block. This can pose a bug risk.
Bad practice
def some_function():
try:
with open('myfile.txt') as file:
data = file.read()
except FileNotFoundError:
print(fnf_error)
finally:
return data
Recommended
def some_function():
try:
with open('myfile.txt') as file:
data = file.read()
except FileNotFoundError:
print(fnf_error)
return data