Unused variable found PYL-W0612
Anti-pattern
3 months ago
—
6 months old
Unused variable 'db_dive_msg'
368)
369async def db_dive(_, message: Message):
370 dburl = Config.MONGODB_URL
371 db_dive_msg = await message.reply(372 f"🚧 Go on [MongoDB.com](https://account.mongodb.com/account/login?nds=true), u stupid 😐\n\nCreds here : `{dburl}`"
373 )
374Unused variable 'db_msg'
358async def db_info(_, message: Message):
359 users_list = await get_users_list()
360 try:
361 db_msg = await message.reply(f"🚧 There you go :\n\n`{users_list}`")362 except:
363 await message.reply("too much users, don't fit into 1 message")
364Unused variable 'startid'
115 "Send me **all** the splitted files (.001, .002, .00×, …)\n\nOnce you sent them all, click on the `Merge 🛠️` button",
116 reply_markup=Buttons.MERGE_THEM_ALL,
117 )
118 startid = merge_msg.id + 1119 # Catch the files id + download + send to callbacks + cat + prompt dialog
120
121Unused variable 'timenow'
9 now = time.time()
10 diff = now - start
11 if round(diff % 10.00) == 0 or current == total:
12 timenow = round(time.time() - start) * 1000 13 percentage = current * 100 / total
14 speed = current / diff
15 elapsed_time = round(diff) * 1000
Description
An unused variable takes up space in the code, and can lead to confusion, and it should be removed. If this variable is necessary, name the variable _ to indicate that it will be unused, or start the name with unused or _unused.
Bad practice
def update():
for i in range(10): # Usused variable `i`
time.sleep(0.01)
display_result()
Preferred:
def update():
for _ in range(10):
time.sleep(0.01)
display_result()