Unused method receiver RVV-B0013
Bug risk
Major
a year ago
—
2 years old
Method receiver 'that' is not referenced in method's body, consider removing or renaming it as _
17}
18
19// GenerateHeader Before Data Transfer, Exchange Arguments G and H.
20func (that *Body) GenerateHeader (dealer *pedersonCommitment.DealerUnit) *Header { 21 // TODO Start with HeaderRandom.
22 header := &Header{
23 Merkle: nil,Method receiver 'that' is not referenced in method's body, consider removing or renaming it as _
233 return that.VerifyFrom(that.Genesis)
234}
235
236func (that *SingleChain) VerifyFrom(block *SingleBlock) bool {237 for nil != block.Next {
238 block = block.Next
239 if !block.Verify(block.Back) {Method receiver 'that' is not referenced in method's body, consider removing or renaming it as _
135 Bases []*Block `json:"bases" yaml:"bases"`
136}
137
138func (that *Blockchain) Verify() bool {139 return true
140}
141Method receiver 'that' is not referenced in method's body, consider removing or renaming it as _
18}
19
20// readGradient TODO Read from File or Transfer between Processes.
21func (that *Peer) readGradient(path string) []float64 {22 return []float64{}
23}
24Method receiver 'that' is not referenced in method's body, consider removing or renaming it as _
64 <-ch
65}
66
67func (that *Peer) sleep(t time.Duration) {68 time.Sleep(t)
69}
70
Description
Methods with unused receivers can be a symptom of unfinished refactoring or a bug. To keep the same method signature, omit the receiver name or '_' as it is unused.
Bad practice
func (f *Unix) Name() string {
return "unix"
}
func (_ *Unix) Name() string {
return "unix"
}
Recommended
func (*Unix) Name() string {
return "unix"
}