Value assigned to a variable is never read before being overwritten SCC-SA4006
Bug risk
Critical
a year ago
—
2 years old
this value of errIn is never used
36 log.Println("Method join send neighbor back failed,", errIn)
37 return
38 }
39 pack, errIn := json.Marshal(Package{40 Type: UdpMethodReceive,
41 Message: d,
42 })this value of _result is never used
18 config := &openapi.Config{}
19 config.Protocol = tea.String("https")
20 config.RegionId = tea.String("central")
21 _result = &dingtalkcontact_1_0.Client{}22 _result, _err = dingtalkcontact_1_0.NewClient(config)
23 return _result, _err
24}this value of _result is never used
22 config := &openapi.Config{}
23 config.Protocol = tea.String("https")
24 config.RegionId = tea.String("central")
25 _result = &dingtalkoauth2_1_0.Client{}26 _result, _err = dingtalkoauth2_1_0.NewClient(config)
27 return _result, _err
28}this value of err is never used
61 if nil != err {
62 return err
63 }
64 err = pem.Encode(privateKeyFile, block)65
66 publicKey := privateKey.Public()
67 blockText, err = x509.MarshalPKIXPublicKey(&publicKey)this value of err is never used
64 err = pem.Encode(privateKeyFile, block)
65
66 publicKey := privateKey.Public()
67 blockText, err = x509.MarshalPKIXPublicKey(&publicKey)68 block = &pem.Block{
69 Type: "ecdsa public key",
70 Headers: nil,
Description
Value has been assigned to a variable, but it is being overwritten before being read. In most cases, this could be a forgotten error check or dead code.
Bad practice
err := Op1()
// error value assigned to "err" by "Op1" is replaced with
// error value assigned by "Op2" before even being read even
// once
err = Op2()
if err != nil {
return err
}
Recommended
// Ignore the error value returned by "Op1"
Op1()
err := Op2()
if err != nil {
return err
}
err := Op1()
// Read the error value assigned to "err" by "Op1"
if err != nil {
return err
}
err = Op2()
if err != nil {
return err
}