The result of append is not used anywhere SCC-SA4010
Bug risk
Critical
2 years ago
—
2 years old
this result of append is never used, except maybe in other appends
29 cmds = []string{} // skip
30
31 // golang
32 cmds = append(cmds, environment.DownloadGoCommand(config.GoDownloadPath, config.GoVersion, config.OS, config.Arch)...)33 cmds = append(cmds, environment.OpenGoWithTarCommand(config.GoVersion, config.OS, config.Arch)...)
34 cmds = append(cmds, environment.ExportGoEnvironmentCommand()...)
35this result of append is never used, except maybe in other appends
20
21 // docker
22 cmds = append(cmds, environment.InstallDockerCommand()...)
23 cmds = append(cmds, environment.CheckDockerCommand()...)24 cmds = append(cmds, environment.CheckDockerComposeCommand()...)
25 cmds = append(cmds, environment.SetDockerImageOriginCommand()...)
26 cmds = append(cmds, environment.RestartDockerCommand()...)this result of append is never used, except maybe in other appends
23 cmds = append(cmds, environment.CheckDockerCommand()...)
24 cmds = append(cmds, environment.CheckDockerComposeCommand()...)
25 cmds = append(cmds, environment.SetDockerImageOriginCommand()...)
26 cmds = append(cmds, environment.RestartDockerCommand()...)27 cmds = append(cmds, environment.PullFabricDockerImagesCommand(config.FabricVersion, config.FabricCaVersion)...)
28
29 cmds = []string{} // skipthis result of append is never used, except maybe in other appends
24 cmds = append(cmds, environment.CheckDockerComposeCommand()...)
25 cmds = append(cmds, environment.SetDockerImageOriginCommand()...)
26 cmds = append(cmds, environment.RestartDockerCommand()...)
27 cmds = append(cmds, environment.PullFabricDockerImagesCommand(config.FabricVersion, config.FabricCaVersion)...)28
29 cmds = []string{} // skip
30this result of append is never used, except maybe in other appends
19 cmds = append(cmds, environment.InstallBuildEssentialCommand()...)
20
21 // docker
22 cmds = append(cmds, environment.InstallDockerCommand()...)23 cmds = append(cmds, environment.CheckDockerCommand()...)
24 cmds = append(cmds, environment.CheckDockerComposeCommand()...)
25 cmds = append(cmds, environment.SetDockerImageOriginCommand()...)
Description
The result of append is not used anywhere.
The append built-in function appends elements to the end of a slice.
If it has sufficient capacity, the destination is resliced to accommodate the
new elements. If it does not, a new underlying array will be allocated.
append returns the updated slice. It is, therefore, often recommended to store
the result of append in the variable holding the slice itself.
Bad practice
a := []int{1, 2}
append(a, 3)
// Value of a is still [1, 2] as when append(a, 3) is called,
// a newly underlyting array is allocated and it is necessary
// to store the update slice descriptor returned by append.
Recommended
a := []int{1, 2}
a = append(a, 3)