Methods must not be empty JAVA-W1004
Anti-pattern
Minor
a year ago
—
a year old
onCancelled should not be empty
69 }
70
71 @Override
72 public void onCancelled(@NonNull DatabaseError error) {7374 }75 });
76
77 }else{onCancelled should not be empty
50 }
51
52 @Override
53 public void onCancelled(@NonNull DatabaseError error) { 54 55 } 56 });
57 }
58onCancelled should not be empty
116 }
117
118 @Override
119 public void onCancelled(@NonNull DatabaseError error) {120121 }122 });
123
124 DatabaseReference reference2 = FirebaseHelper.getDatabaseReference()onCancelled should not be empty
145 }
146
147 @Override
148 public void onCancelled(@NonNull DatabaseError error) {149150 }151 });
152 }
153OnClickListener should not be empty
106 }
107
108 @Override
109 public void OnClickListener(Reserva reserva) {110111 }112}
Description
This method is empty and does not appear to have any explanation regarding why. This may confuse future readers of this code. Additionally, such code produces needless, avoidable clutter.
Bad Practice
void method() {
}
Recommended
If the method overrides a parent implementation and is left empty to prevent default behavior, consider documenting why with a comment:
@Override
void method() {
// left empty because of ...
}