Method uses the same code for multiple branches JAVA-W0411
Anti-pattern
Minor
2 years ago
—
2 years old
This branch is duplicated elsewhere in this block
553 return string(obj.toString());
554 } else if (obj instanceof URI) {
555 return string(obj.toString());
556 } else if (obj instanceof JsonPath) { 557 return string(obj.toString()); 558 } else if (obj instanceof Enum) { 559 return string(((Enum<?>) obj).name());
560 } else if (obj instanceof Stream) {
561 // Stream -> ArrayThis branch is duplicated elsewhere in this block
547 return string((String) obj);
548 } else if (obj instanceof File) {
549 return string(obj.toString());
550 } else if (obj instanceof Path) { 551 return string(obj.toString()); 552 } else if (obj instanceof URL) { 553 return string(obj.toString());
554 } else if (obj instanceof URI) {
555 return string(obj.toString());This branch is duplicated elsewhere in this block
551 return string(obj.toString());
552 } else if (obj instanceof URL) {
553 return string(obj.toString());
554 } else if (obj instanceof URI) { 555 return string(obj.toString()); 556 } else if (obj instanceof JsonPath) { 557 return string(obj.toString());
558 } else if (obj instanceof Enum) {
559 return string(((Enum<?>) obj).name());This branch is duplicated elsewhere in this block
549 return string(obj.toString());
550 } else if (obj instanceof Path) {
551 return string(obj.toString());
552 } else if (obj instanceof URL) { 553 return string(obj.toString()); 554 } else if (obj instanceof URI) { 555 return string(obj.toString());
556 } else if (obj instanceof JsonPath) {
557 return string(obj.toString());This branch is duplicated elsewhere in this block
426 return string((String) obj);
427 } else if (obj instanceof File) {
428 return string(obj.toString());
429 } else if (obj instanceof Path) { 430 return string(obj.toString()); 431 } else if (obj instanceof URL) { 432 return string(obj.toString());
433 } else if (obj instanceof URI) {
434 return string(obj.toString());
Description
This method seems to have the same code for multiple branch statements.
This could be a valid usage for clarity's sake, but it might also indicate a typo.
Bad Practice
if (someCondition) {
System.out.println("a");
System.out.println(1 + new Random().nextInt());
} else if (someOtherCondition) { // The else if block has the same content as the first if block...
System.out.println("a");
System.out.println(1 + new Random().nextInt());
} else if (new Random().nextBoolean()) {
if ("3".equals("4")) System.out.println(3 + new Random().nextInt());
}
Recommended
If the duplication was intended, consider just combining the conditions with an OR operator:
if (someCondition || someOtherCondition) {
System.out.println("a");
System.out.println(1 + new Random().nextInt());
}
References
- SpotBugs - DBDUPLICATEBRANCHES