Methods must not be empty JAVA-W1004
Anti-pattern
Minor
2 years ago
—
2 years old
message_delete should not be empty
54 }
55
56 @Override
57 public void message_delete() {5859 }60
61 @Override
62 public void send_picture(File file) {delete_key should not be empty
42 }
43
44 @Override
45 public void delete_key(String key) {4647 }48}
on_register should not be empty
16 }
17
18 @Override
19 public void on_register() {2021 }22}
on_register should not be empty
16 }
17
18 @Override
19 public void on_register() {2021 }22}
on_register should not be empty
16 }
17
18 @Override
19 public void on_register() {2021 }22}
Description
This method is empty and does not appear to have any explanation regarding why. This may confuse future readers of this code. Additionally, such code produces needless, avoidable clutter.
Bad Practice
void method() {
}
Recommended
If the method overrides a parent implementation and is left empty to prevent default behavior, consider documenting why with a comment:
@Override
void method() {
// left empty because of ...
}