append possibly assigns to a wrong variable CRT-D0001
Bug risk
Minor
2 months ago
—
2 months old
append result not assigned to the same slice
539 if connection.Name() == db.DriverMssql {
540 args = append(whereArgs, (params.PageInt-1)*params.PageSizeInt, params.PageInt*params.PageSizeInt)
541 } else {
542 args = append(whereArgs, params.PageSizeInt, (params.PageInt-1)*params.PageSizeInt) 543 }
544 }
545append result not assigned to the same slice
537 }
538
539 if connection.Name() == db.DriverMssql {
540 args = append(whereArgs, (params.PageInt-1)*params.PageSizeInt, params.PageInt*params.PageSizeInt) 541 } else {
542 args = append(whereArgs, params.PageSizeInt, (params.PageInt-1)*params.PageSizeInt)
543 }
Description
The builtin function append returns the updated slice after the append operation.
This resulting slice is usually assigned back to the same variable that contained
the original slice to which new values were appended.
Bad practice
x = []int{1, 3, 5}
append(x, 7) // returns the value []int{1, 3, 5, 7}. This is usually assigned back to x
x := []int{}
y := []int{}
x = append(y, 1) // possibly wrong
Recommended
x = []int{1, 3, 5}
x = append(x, 7)
x := []int{}
y := []int{}
y = append(y, 1) // append 1 to y