string to int signedness casting GO-E1006
Bug risk
Critical
2 months ago
—
a year old
string to int signedness cast "uint8(detailDisplay)", might result in lost or misinterpreted data
1798 FilterFormLayout: form.GetLayoutFromString(values.Get("filter_form_layout")),
1799 Schema: values.Get("schema"),
1800 Output: output,
1801 DetailDisplay: uint8(detailDisplay),1802 FormTitle: values.Get("form_title"),
1803 FormDescription: values.Get("form_description"),
1804 DetailTitle: values.Get("detail_title"),string to int signedness cast "int8(loggerLevel)", might result in lost or misinterpreted data
779
780 c.Logger.Encoder.Encoding = m["logger_encoder_encoding"]
781 loggerLevel, _ := strconv.Atoi(m["logger_level"])
782 c.Logger.Level = int8(loggerLevel) 783
784 if c.Logger.Encoder.Encoding == "json" {
785 c.Logger.Encoder.TimeKey = m["logger_encoder_time_key"]
Description
It is possible for integer casting, if not appropriately done to lose the signedness of the integer and might cause overflow as well.
For example:
- int64 must not be casted to: "uint8", "uint16", "uint32", "uint64", "int8", "int16", "int32"
int64 can lose signedness if converted to unsigned integer and if converted to
a signed integer but a type other than int64, then overflow might occur.
uint64must not be casted to: "uint8", "uint16", "uint32", "int8", "int16", "int32", "int64"uint64would lose signedness if converted to a signed integer and might overflow. If converted to an unsigned integer, i.e., a type other thanuint64, overflow might occur.
Bad practice
n, err := strconv.Atoi("42")
if err != nil {
panic(err)
}
// `n` is of type `int`, so it is either `int64` or `int32` depending on the platform.
// Casting it to `uint8` might result in loss of signedness of the integer and might
// not give expected results.
_ = uint8(n)