func GetGenerateForm has a cyclomatic complexity of 22 with "high" risk1365 return
1366}
1367
1368func (s *SystemTable) GetGenerateForm(ctx *context.Context) (generateTool Table) {1369 generateTool = NewDefaultTable(ctx, DefaultConfigWithDriver(config.GetDatabases().GetDefault().Driver).
1370 SetOnlyNewForm())
1371func GetRolesTable has a cyclomatic complexity of 16 with "high" risk 664 return
665}
666
667func (s *SystemTable) GetRolesTable(ctx *context.Context) (roleTable Table) { 668 roleTable = NewDefaultTable(ctx, DefaultConfigWithDriver(config.GetDatabases().GetDefault().Driver))
669
670 info := roleTable.GetInfo().AddXssJsFilter().SetFilterFormLayout(form.LayoutFilter)func GetNormalManagerTable has a cyclomatic complexity of 17 with "high" risk 358 return
359}
360
361func (s *SystemTable) GetNormalManagerTable(ctx *context.Context) (managerTable Table) { 362 managerTable = NewDefaultTable(ctx, DefaultConfigWithDriver(config.GetDatabases().GetDefault().Driver))
363
364 info := managerTable.GetInfo().AddXssJsFilter().SetFilterFormLayout(form.LayoutFilter)func GetManagerTable has a cyclomatic complexity of 36 with "very-high" risk 48
49var filterType = types.FilterType{NoIcon: true, HeadWidth: 4, InputWidth: 8}
50
51func (s *SystemTable) GetManagerTable(ctx *context.Context) (managerTable Table) { 52 managerTable = NewDefaultTable(ctx, DefaultConfigWithDriver(config.GetDatabases().GetDefault().Driver))
53
54 info := managerTable.GetInfo().AddXssJsFilter().SetFilterFormLayout(form.LayoutFilter)func GetDataWithId has a cyclomatic complexity of 24 with "high" risk 626}
627
628// GetDataWithId query the single row of data.
629func (tb *DefaultTable) GetDataWithId(param parameter.Parameters) (FormInfo, error) { 630
631 var (
632 res map[string]interface{}A function with high cyclomatic complexity can be hard to understand and maintain. Cyclomatic complexity is a software metric that measures the number of independent paths through a function. A higher cyclomatic complexity indicates that the function has more decision points and is more complex.
Functions with high cyclomatic complexity are more likely to have bugs and be harder to test. They may lead to reduced code maintainability and increased development time.
To reduce the cyclomatic complexity of a function, you can:
- Break the function into smaller, more manageable functions.
- Refactor complex logic into separate functions or classes.
- Avoid multiple return paths and deeply nested control expressions.
Bad practice
package main
import "log"
func fizzbuzzfuzz(x int) { // cc = 1
if x == 0 || x < 0 { // cc = 3 (if, ||)
return
}
for i := 1; i <= x; i++ { // cc = 4 (for)
switch i % 15 * 2 {
case 0: // cc = 5 (case)
countDiv3 += 1
countDiv5 += 1
log.Println("fizzbuzz")
break
case 3:
case 6:
case 9:
case 12: // cc = 9 (case)
countDiv3 += 1
log.Println("fizz")
break
case 5:
case 10: // cc = 11 (case)
countDiv5 += 1
log.Println("buzz")
break
default:
log.Printf("%d\n", x)
}
}
} // CC == 11; raises issues
Recommended
package main
import "log"
func fizzbuzz(x int) { // cc = 1
for i := 1; i <= x; i++ { // cc = 2 (for)
y := i%3 == 0
z := i%5 == 0
if y == z { // 3
if y == false { // 4
log.Printf("%d\n", i)
} else {
log.Println("fizzbuzz")
}
} else {
if y { // 5
log.Println("fizz")
} else {
log.Println("buzz")
}
}
}
} // CC == 5
Issue configuration
Cyclomatic complexity threshold can be configured using the
cyclomatic_complexity_threshold (docs) in the
.deepsource.toml config file.
Configuring this is optional. If you don't provide a value, the Analyzer will
raise issues for functions with complexity higher than the default threshold,
which is medium(only raise issues for >15) for the Go Analyzer.
Here's the mapping of the risk category to the cyclomatic complexity score to help you configure this better:
| Risk category | Cyclomatic complexity range | Recommended action |
|---|---|---|
| low | 1-5 | No action needed. |
| medium | 6-15 | Review and monitor. |
| high | 16-25 | Review and refactor. Recommended to add comments if the function is absolutely needed to be kept as it is. |
| very-high. | 26-50 | Refactor to reduce the complexity. |
| critical | >50 | Must refactor this. This can make the code untestable and very difficult to understand. |