Functions prefixed with
Get should return a value RVV-A0006
Anti-pattern
Major
a month ago
—
2 years old
function 'GetContent' seems to be a getter but it does not return any result
135func (*BaseAdapter) Static(_, _ string) { panic("not implement") }
136
137// GetContent is a helper function of adapter.Content
138func (base *BaseAdapter) GetContent(ctx interface{}, getPanelFn types.GetPanelFn, wf WebFrameWork,139 navButtons types.Buttons, fn context.NodeProcessor) {
140
141 var (function 'getMenuInfoPanel' seems to be a getter but it does not return any result
247 response.Ok(ctx)
248}
249
250func (h *Handler) getMenuInfoPanel(ctx *context.Context, plugName string, alert template2.HTML) {251 user := auth.Auth(ctx)
252
253 if plugName == "" {
Description
Typically, functions with names prefixed with Get are supposed to return a value.
Bad practice
func GetData(n int) {
fmt.Println(10 - n)
}
Recommended
func GetData(n int) int {
fmt.Println(10 - n)
return 10 - n
}