Confusing naming of struct fields or methods RVV-B0001
Bug risk
Minor
a month ago
—
2 years old
Method 'addXssJsFilter' differs only by capitalization to function 'AddXssJsFilter' in the same source file
331 return chains
332}
333
334func addXssJsFilter(chains DisplayProcessFnChains) DisplayProcessFnChains {335 chains = chains.Add(func(value FieldModel) interface{} {
336 replacer := strings.NewReplacer("<script>", "<script>", "</script>", "</script>")
337 return replacer.Replace(value.Value)Method 'addXssFilter' differs only by capitalization to function 'AddXssFilter' in the same source file
324 return chains
325}
326
327func addXssFilter(chains DisplayProcessFnChains) DisplayProcessFnChains {328 chains = chains.Add(func(value FieldModel) interface{} {
329 return html.EscapeString(value.Value)
330 })Method 'addToLower' differs only by capitalization to function 'AddToLower' in the same source file
317 return chains
318}
319
320func addToLower(chains DisplayProcessFnChains) DisplayProcessFnChains {321 chains = chains.Add(func(value FieldModel) interface{} {
322 return strings.ToLower(value.Value)
323 })Method 'addToUpper' differs only by capitalization to function 'AddToUpper' in the same source file
310 return chains
311}
312
313func addToUpper(chains DisplayProcessFnChains) DisplayProcessFnChains {314 chains = chains.Add(func(value FieldModel) interface{} {
315 return strings.ToUpper(value.Value)
316 })Method 'addToTitle' differs only by capitalization to function 'AddToTitle' in the same source file
303 return chains
304}
305
306func addToTitle(chains DisplayProcessFnChains) DisplayProcessFnChains {307 chains = chains.Add(func(value FieldModel) interface{} {
308 return cases.Title(language.Und).String(value.Value)
309 })
Description
Methods or fields of struct that have names different only by capitalization could be confusing.
Bad practice
type SomeType struct {
// actual build system to be inferred, based on the `BuildSystem` passed by user
buildSystem string
// name of the build system to use
BuildSystem string
}
Recommended
type SomeType struct {
// actual build system to be inferred, based on the `BuildSystem` passed by user
internalBuildSystem string
// name of the build system to use
BuildSystem string
}