Method modifies receiver RVV-B0006
Bug risk
Major
2 months ago
—
2 years old
suspicious assignment to a by-value method receiver
458 f.Delete = utils.SetDefault(f.Delete, "", "/delete/:__prefix")
459 f.Export = utils.SetDefault(f.Export, "", "/export/:__prefix")
460 f.Info = utils.SetDefault(f.Info, "", "/info/:__prefix")
461 f.Update = utils.SetDefault(f.Update, "", "/update/:__prefix") 462 return f
463}
464suspicious assignment to a by-value method receiver
457 f.Create = utils.SetDefault(f.Create, "", "/new/:__prefix")
458 f.Delete = utils.SetDefault(f.Delete, "", "/delete/:__prefix")
459 f.Export = utils.SetDefault(f.Export, "", "/export/:__prefix")
460 f.Info = utils.SetDefault(f.Info, "", "/info/:__prefix") 461 f.Update = utils.SetDefault(f.Update, "", "/update/:__prefix")
462 return f
463}suspicious assignment to a by-value method receiver
456 f.Edit = utils.SetDefault(f.Edit, "", "/edit/:__prefix")
457 f.Create = utils.SetDefault(f.Create, "", "/new/:__prefix")
458 f.Delete = utils.SetDefault(f.Delete, "", "/delete/:__prefix")
459 f.Export = utils.SetDefault(f.Export, "", "/export/:__prefix") 460 f.Info = utils.SetDefault(f.Info, "", "/info/:__prefix")
461 f.Update = utils.SetDefault(f.Update, "", "/update/:__prefix")
462 return fsuspicious assignment to a by-value method receiver
455 f.ShowCreate = utils.SetDefault(f.ShowCreate, "", "/info/:__prefix/new")
456 f.Edit = utils.SetDefault(f.Edit, "", "/edit/:__prefix")
457 f.Create = utils.SetDefault(f.Create, "", "/new/:__prefix")
458 f.Delete = utils.SetDefault(f.Delete, "", "/delete/:__prefix") 459 f.Export = utils.SetDefault(f.Export, "", "/export/:__prefix")
460 f.Info = utils.SetDefault(f.Info, "", "/info/:__prefix")
461 f.Update = utils.SetDefault(f.Update, "", "/update/:__prefix")suspicious assignment to a by-value method receiver
454 f.ShowEdit = utils.SetDefault(f.ShowEdit, "", "/info/:__prefix/edit")
455 f.ShowCreate = utils.SetDefault(f.ShowCreate, "", "/info/:__prefix/new")
456 f.Edit = utils.SetDefault(f.Edit, "", "/edit/:__prefix")
457 f.Create = utils.SetDefault(f.Create, "", "/new/:__prefix") 458 f.Delete = utils.SetDefault(f.Delete, "", "/delete/:__prefix")
459 f.Export = utils.SetDefault(f.Export, "", "/export/:__prefix")
460 f.Info = utils.SetDefault(f.Info, "", "/info/:__prefix")
Description
A method that modifies its receiver value can have undesired behavior. The modification can also be the root of a bug because the actual value receiver could be a copy of that used at the calling site. This rule warns when a method modifies its receiver.
Bad practice
type data struct {
num int
key *string
items map[string]bool
}
func (d data) vmethod() {
d.num = 8
}
Recommended
type data struct {
num int
key *string
items map[string]bool
}
func (d *data) vmethod() {
d.num = 8
}