Initialization in variable declarations against recommended approach JS-0119
Anti-pattern
Minor
a year ago
—
2 years old
Variable 'i' should be initialized on declaration
1function generatePrimes(primes, MAX_SIZE){
2 let IsPrime = Array(MAX_SIZE).fill(true);
3
4 let p,i; 5 for (p = 2; p * p < MAX_SIZE;p++) {
6 if (IsPrime[p] == true) {
7 for(i = p * p; i < MAX_SIZE; i += p)Variable 'p' should be initialized on declaration
1function generatePrimes(primes, MAX_SIZE){
2 let IsPrime = Array(MAX_SIZE).fill(true);
3
4 let p,i; 5 for (p = 2; p * p < MAX_SIZE;p++) {
6 if (IsPrime[p] == true) {
7 for(i = p * p; i < MAX_SIZE; i += p)
Description
In JavaScript, variables can be assigned during declaration, or at any point afterwards using an assignment statement. For example, in the following code, foo is initialized during declaration, while bar is initialized later.
var foo = 1;
var bar;
if (foo) {
bar = 1;
} else {
bar = 2;
}
Bad Practice
function foo() {
var bar;
let baz;
}
Recommended
function foo() {
var bar = 1;
let baz = 2;
const qux = 3;
}