Unnecessary generator PTC-W0015
Anti-pattern
Major
a year ago
—
a year old
Unnecessary generator - rewrite as a list comprehension
1from functools import reduce
2
3def main():
4 return sum(list(int(j) for j in str(reduce(lambda x, y: x*y, range(1, 101)))))5
6print(main())Unnecessary generator - rewrite as a list comprehension
2def main():
3 n = "7316717653133062491922511967442657474235534919493496983520312774506326239578318016984801869478851843858615607891129494954595017379583319528532088055111254069874715852386305071569329096329522744304355766896648950445244523161731856403098711121722383113622298934233803081353362766142828064444866452387493035890729629049156044077239071381051585930796086670172427121883998797908792274921901699720888093776657273330010533678812202354218097512545405947522435258490771167055601360483958644670632441572215539753697817977846174064955149290862569321978468622482839722413756570560574902614079729686524145351004748216637048440319989000889524345065854122758866688116427171479924442928230863465674813919123162824586178664583591245665294765456828489128831426076900422421902267105562632111110937054421750694165896040807198403850962455444362981230987879927244284909188845801561660979191338754992005240636899125607176060588611646710940507754100225698315520005593572972571636269561882670428252483600823257530420752963450"
4
5 return max(prod(list(int(c) for c in n[i:i+13])) for i in range(len(n)-13+1))6
7print(main())Unnecessary generator - rewrite as a set comprehension
36 Returns:
37 factors - a set of the factors of n
38 """
39 return set(f for i in range(1, int(n**0.5)+1) if n % i == 0 for f in [i, n//i]) 40
41def isPalendromic(n):
42 """
Description
It is unnecessary to use list, set, dict around a generator expression to get an object of that type since there are comprehensions for these types.
Bad practice
squares = list(x**2 for x in range(1, 10))
large_numbers = set(n for n in numbers if n > 1000)
tree_counts = dict((tree, counts[tree]) for tree in trees)
Recommended
squares = [x**2 for x in range(1, 10)]
large_numbers = {n for n in numbers if n > 1000}
tree_counts = {tree: counts[tree] for tree in trees}