Unused variable found PYL-W0612
Anti-pattern
Major
a year ago
—
a year old
Unused variable 'DOWNLOADED'
9 with open(f"html/p{str(i).zfill(3)}-MINIMAL.html", "w", encoding="utf-8") as pfile:
10 soup = BeautifulSoup(res.text, "html.parser")
11 pfile.write(soup.prettify())
12 DOWNLOADED = True_13
14def downloadAll():
15 for i in range(1, 773):Unused variable 'DOWNLOADED'
17 with open(f"html/p{str(i).zfill(3)}.html", "w", encoding="utf-8") as pfile:
18 soup = BeautifulSoup(res.text, "html.parser")
19 pfile.write(soup.prettify())
20 DOWNLOADED = True_21
22minimal = True
23DOWNLOADED = False
Description
An unused variable takes up space in the code, and can lead to confusion, and it should be removed. If this variable is necessary, name the variable _ to indicate that it will be unused, or start the name with unused or _unused.
Bad practice
def update():
for i in range(10): # Usused variable `i`
time.sleep(0.01)
display_result()
Preferred:
def update():
for _ in range(10):
time.sleep(0.01)
display_result()