Re-defined variable from outer scope PYL-W0621
Anti-pattern
Major
a year ago
—
a year old
Redefining name 'DOWNLOADED' from outer scope (line 23)
9 with open(f"html/p{str(i).zfill(3)}-MINIMAL.html", "w", encoding="utf-8") as pfile:
10 soup = BeautifulSoup(res.text, "html.parser")
11 pfile.write(soup.prettify())
12 DOWNLOADED = True_13
14def downloadAll():
15 for i in range(1, 773):Redefining name 'DOWNLOADED' from outer scope (line 23)
17 with open(f"html/p{str(i).zfill(3)}.html", "w", encoding="utf-8") as pfile:
18 soup = BeautifulSoup(res.text, "html.parser")
19 pfile.write(soup.prettify())
20 DOWNLOADED = True_21
22minimal = True
23DOWNLOADED = False
Description
The local variable name hides the variable defined in the outer scope, making it inaccessible and might confuse.
Bad practice
filename = 'myfile.txt'
def read_file(filename): # This shadows the global `filename`
with open(filename) as file:
return file.readlines()
Preferred:
FILENAME = 'myfile.txt' # renamed global to UPPER_CASE as convention
def read_file(filename):
with open(filename) as file:
return file.readlines()
Bad practice
Another usual suspect of this is when you use the same parameter name inside a function as the global variable you are using. For example:
def run_app(app):
# This `app` shadows the global app...
app.run()
if __name__ == '__main__':
app = MyApp() # This is a global variable!
run_app(app)
Preferred:
To avoid this re-defining of a global, consider not defining app as a global, but inside a main() function instead:
def run_app(app):
# There is no longer a global `app` variable.
app.run()
def main():
app = MyApp()
run_app(app)
if __name__ == '__main__':
main()