PY-W0069 @ 15bd11d • HHousen / TransformerSum

Run summary

2 years ago

176d394..15bd11d

19 s

Consider removing the commented out code block PY-W0069

Anti-pattern

Major

7 occurrences in this check

Consider removing the commented out code block

src/extractive.py

1139            outputs = torch.sigmoid(outputs)
1140
1141        if raw_scores:
1142            # key=sentence1143            # value=score
1144            sent_scores = list(zip(src_txt, outputs.tolist()[0]))
1145            return sent_scores

Consider removing the commented out code block

src/extractive.py

 688        test_dataloader = DataLoader(
 689            test_dataset,
 690            num_workers=self.hparams.dataloader_num_workers,
 691            # sampler=test_sampler, 692            batch_size=self.hparams.batch_size,
 693            collate_fn=self.pad_batch_collate,
 694        )

Consider removing the commented out code block

src/extractive.py

 672        valid_dataloader = DataLoader(
 673            valid_dataset,
 674            num_workers=self.hparams.dataloader_num_workers,
 675            # sampler=valid_sampler, 676            batch_size=self.hparams.batch_size,
 677            collate_fn=self.pad_batch_collate,
 678        )

Consider removing the commented out code block

src/extractive.py

 658        train_dataloader = DataLoader(
 659            train_dataset,
 660            num_workers=self.hparams.dataloader_num_workers,
 661            # sampler=train_sampler, 662            batch_size=self.hparams.batch_size,
 663            collate_fn=self.pad_batch_collate,
 664        )

Consider removing the commented out code block

src/extractive.py

 585                    zip(range(len(json_files)), json_files),
 586                ):
 587                    pass
 588                # pool.close() 589                # pool.join()
 590
 591                # since the dataset has been prepared, the processed dataset files should

Consider removing the commented out code block

src/extractive.py

 571
 572                num_files = len(json_files)
 573
 574                # pool = Pool(self.hparams.num_threads) 575                json_to_dataset_processor = partial(
 576                    self.json_to_dataset,
 577                    self.tokenizer,

Consider removing the commented out code block

src/extractive.py

  31logger = logging.getLogger(__name__)
  32
  33
  34# CUSTOM_MODEL_CLASSES = ("longformer",)  35
  36try:
  37    from transformers.models.auto.modeling_auto import MODEL_MAPPING_NAMES

Description

It is recommended to remove any commented code in your codebase.

Bad practice

for item in sequence:
    # print(item)
    do_something(item)

# def old_function():
#     '''Older implementation that has been replaced'''
#     data = get_data()
#     api.post(data)

HHousen / TransformerSum

Bad practice

Recommended