Attribute defined outside
__init__ PYL-W0201
Anti-pattern
Minor
3 years ago
—
4 years old
Attribute 'first_slide_frame_num' defined outside __init__
205 self.root_process_folder / "first-frame-num.txt",
206 )
207 first_slide_frame_filename = sorted(os.listdir(slides_dir))[0]
208 self.first_slide_frame_num = frame_number_from_filename(209 first_slide_frame_filename
210 )
211 with open(first_frame_num_file_path, "a") as first_frame_num_file:Attribute 'slides_noborder_dir' defined outside __init__
228 self.frames_sorted_dir = getattr(
229 self, "frames_sorted_dir", self.root_process_folder / "frames_sorted"
230 )
231 self.slides_noborder_dir = getattr(232 self, "slides_noborder_dir", self.frames_sorted_dir / "slides_noborder"
233 )
234Attribute 'slides_noborder_dir' defined outside __init__
314 self.imgs_to_cluster_dir = getattr(
315 self, "imgs_to_cluster", self.frames_sorted_dir / "imgs_to_cluster"
316 )
317 self.slides_noborder_dir = getattr(318 self, "slides_noborder_dir", self.frames_sorted_dir / "slides_noborder"
319 )
320Attribute 'imgs_to_cluster_dir' defined outside __init__
311 self.frames_sorted_dir = getattr(
312 self, "frames_sorted_dir", self.root_process_folder / "frames_sorted"
313 )
314 self.imgs_to_cluster_dir = getattr(315 self, "imgs_to_cluster", self.frames_sorted_dir / "imgs_to_cluster"
316 )
317 self.slides_noborder_dir = getattr(Attribute 'cluster_dir' defined outside __init__
356 self.frames_sorted_dir = getattr(
357 self, "frames_sorted_dir", self.root_process_folder / "frames_sorted"
358 )
359 self.cluster_dir = getattr(360 self, "cluster_dir", self.frames_sorted_dir / "slide_clusters"
361 )
362 self.best_samples_dir = getattr(
Description
Defining an instance attribute outside __init__ affects the readability of code. It is expected to find all the attributes an instance may have by reading its __init__ method. If there is a need to initialize attribute via sub-initialization methods, it is recommended to assign attributes to None in the init then call the sub-initialization methods.