Test for object identity should be 'is not' FLK-E714
Style
3 months ago
—
3 months old
test for object identity should be 'is not'
59 time: Optional[int] = Body(default=None),
60):
61 run = Run[id]
62 optimal = not time is None63
64 solver = select(s for s in Solver if s.name == solver)[:][0]
65 if not solver:
Description
Tests for object identity should use the form x is not None rather than not x is None. The former example is more readable.
Not preferred:
value = get_result()
if not value is None:
print(value)
Preferred:
value = get_result()
if value is not None:
print(value)