Consider using
in PYL-R1714
Performance
Major
a year ago
—
a year old
Consider merging these comparisons with 'in' by using 'run.status.id in (Run_status.RUNNING, Run_status.PROVING_OPTIMALITY)'. Use a set instead if elements are hashable.
220 if run.user.id != user_id and not bool(User[user_id].sys_admin):
221 raise HTTPException(status_code=401, detail="Access denied")
222 if (
223 run.status.id == Run_status.RUNNING224 or run.status.id == Run_status.PROVING_OPTIMALITY
225 ):
226 resp = requests.post(
Description
To check if a variable is equal to one of many values, combine the values into a tuple and check if the variable is contained in it instead of checking for equality against each of the values.
This is faster, less verbose, and more readable.
Bad practice
if x == 1 or x == 2 or x == 3:
do_something()
Recommended
if x in (1, 2, 3):
do_something()