Redundant list comprehension can be replaced using generator PYL-R1728
Performance
Minor
a year ago
—
a year old
Consider using a generator instead 'sum(len(run.run__solvers.select(lambda runSolver: not runSolver.terminated)) * run.flag_processors for run in select((run for run in Run if run.status.id in (Run_status.RUNNING, Run_status.PROVING_OPTIMALITY) and run.user.id == user_id))[:])'
64
65 if (
66 len(solvers) * flag_processors
67 + sum( 68 [
69 len(run.run__solvers.select(lambda runSolver: not runSolver.terminated))
70 * run.flag_processors
Description
Using a container in place of a generator for a calls that can accept both, slows down the performance. Consider using generators for all function calls which accept both containers and genertors.
Bad practice
# List comprehension is unnecessary here
set([student.name for student in student])
sum([y**2 for y in list(range(10))])
Recommended
set(student.name for student in students)
sum(y**2 for y in list(range(10)))