Exception caught is very general PYL-W0703
Anti-pattern
Major
a year ago
—
a year old
Catching too general exception Exception
157 )
158 )
159
160 except Exception as e:161 result["status"] = type(e).__name__
162 result["solution"] = str(e)
163Catching too general exception Exception
35 ):
36 try:
37 api_instance.create_namespaced_job(body=job_object, namespace="default")
38 except Exception as e: 39 print(f"Got exception while creating job: {e}")
40 return None
41
Description
If the except block catches a very general exception, it is likely to catch any unrelated errors too. Try to be more explicit about which exception(s) you're trying to catch.
If you need to catch every other exception, then mark it as intentional by
adding a # skipcq comment.
Bad practice
try:
x = a / b
except Exception:
x = a / (b + 1)
try:
line = input('Enter numbers:')
numbers = [int(i) for i in line.split()]
except BaseException:
print('Only use numbers for the input')
Preferred:
try:
x = a / b
except ZeroDivisionError:
x = a / (b + 1)
try:
event_loop.run()
except Exception as exc: # skipcq: PYL-W0703 - Loop can sometimes crash.
sentry.report(exc)
try:
line = input('Enter numbers:')
numbers = [int(i) for i in line.split()]
except ValueError:
print('Only use numbers for the input')