Detected empty functions JS-0321
Anti-pattern
Minor
a month ago
—
2 years old
Unexpected empty arrow function
162 cart={carts.find((cart) => cart.id === activeCart)}
163 cols={COLS}
164 data={data}
165 onDelete={() => {}}166 />
167 ) : (
168 <div className="checkout__body__empty">No items in cart</div>Unexpected empty method 'onLogout'
7const headerProps = {
8 user: {},
9 onLogin: () => {},
10 onLogout: () => {},11};
12const Default = (args: any) => {
13 return (Unexpected empty method 'onLogin'
6
7const headerProps = {
8 user: {},
9 onLogin: () => {},10 onLogout: () => {},
11};
12const Default = (args: any) => {
Description
Having empty functions hurts readability, and is considered a code-smell. There's almost always a way to avoid using them. If you must use one, consider adding a comment to inform the reader of its purpose.
Bad Practice
getUser('SwaGaLisTiQuE', () => {})
Recommended
getUser('SwaGaLisTiQuE', () => {
// empty because <reason>
})