Unnecessary
delete statement in a local scope PTC-W0043
Anti-pattern
Major
6 months ago
—
3 years old
Unnecessary
del statement in a local scope256 unscaled.tofile(file)
257 except UnsupportedOperation:
258 file.write(unscaled.tobytes())
259 del unscaled260
261 @staticmethod
262 def __scale(samples: np.ndarray, factor: float):Unnecessary
del statement in a local scope 66 if p_value:
67 atval = np.abs(tval)
68 p = 2 * t.sf(atval, df)
69 del atval 70 result.append(CombinedTrace(p))
71 return tuple(result)
72Unnecessary
del statement in a local scope 61 bot = (varn_0 ** 2 / (n0 - 1)) + (varn_1 ** 2 / (n1 - 1))
62 df = top / bot
63 del top
64 del bot 65 result.append(CombinedTrace(df))
66 if p_value:
67 atval = np.abs(tval)Unnecessary
del statement in a local scope 60 top = (varn_0 + varn_1) ** 2
61 bot = (varn_0 ** 2 / (n0 - 1)) + (varn_1 ** 2 / (n1 - 1))
62 df = top / bot
63 del top 64 del bot
65 result.append(CombinedTrace(df))
66 if p_value:Unnecessary
del statement in a local scope121 d = np.subtract(t.samples[:min_samples], s)
122 ts = np.add(ts, np.multiply(d, d, dtype=np.float64))
123 var = (1 / (len(traces) - 1)) * ts
124 del ts125 return (CombinedTrace(s), CombinedTrace(var))
126
127
Description
Passing a local variable to a del statement results in that variable being removed from the local namespace.
When exiting a function all local variables are deleted, so it is unnecessary to explicitly delete variables in such cases.
It is recommended to remove this del statement.
Not preferred:
def my_func():
task = do_some_task()
evaluate_task(task)
del task # This is unnecessary.
Preferred:
def my_func():
task = do_some_task()
evaluate_task(task)