Function contains unused argument PYL-W0613
Anti-pattern
Major
6 months ago
—
3 years old
Unused argument 'length'
57 return struct.pack(f"<{'e' if length == 2 else 'f'}", f)
58
59 @staticmethod
60 def write_str(s, length=None): 61 return s.encode("ascii")
62
63Unused argument 'a'
287 d = -4 * a - 3 * alpha ** 2
288 return {"c": c, "d": d}
289
290 def map_point(a, b, pt, aff):291 u = (pt.x - alpha) / pt.y
292 v = (s * (pt.x - alpha) - 1) / (s * (pt.x - alpha) + 1) * t
293 return Point(aff, x=u, y=v)Unused argument 'b'
287 d = -4 * a - 3 * alpha ** 2
288 return {"c": c, "d": d}
289
290 def map_point(a, b, pt, aff):291 u = (pt.x - alpha) / pt.y
292 v = (s * (pt.x - alpha) - 1) / (s * (pt.x - alpha) + 1) * t
293 return Point(aff, x=u, y=v)Unused argument 'b'
282 continue
283 t = t.sqrt()
284
285 def map_parameters(a, b):286 c = t
287 d = -4 * a - 3 * alpha ** 2
288 return {"c": c, "d": d}Unused argument 'b'
252 d = 3 * alpha - 2 * beta
253 return {"a": a, "d": d}
254
255 def map_point(a, b, pt, aff):256 if params.curve.is_neutral(pt):
257 u = Mod(0, params.curve.prime)
258 v = Mod(1, params.curve.prime)
Description
An unused argument can lead to confusions. It should be removed. If this variable is necessary, name the variable _ or start the name with unused or _unused.
Bad practice
def square(x, y=1):
return x * x
class MySubClass(MyClass):
def __init__(self, number):
self.value = 42 # argument `number` remains unused
Preferred:
def square(x):
return x * x
class MySubClass(MyClass):
def __init__(self, _):
self.value = 42