Exception caught is very general PYL-W0703
Anti-pattern
Major
6 months ago
—
3 years old
Catching too general exception Exception
230 for combination in product(*values):
231 try:
232 mult = mult_cls(**dict(zip(keys, combination)))
233 except Exception:234 continue
235 yield mult
236Catching too general exception Exception
36 def flash(self, fw_path: str) -> bool:
37 try:
38 cw.program_target(self.scope, self.programmer, fw_path)
39 except Exception as e:40 print(e)
41 return False
42 return True
Description
If the except block catches a very general exception, it is likely to catch any unrelated errors too. Try to be more explicit about which exception(s) you're trying to catch.
If you need to catch every other exception, then mark it as intentional by
adding a # skipcq comment.
Bad practice
try:
x = a / b
except Exception:
x = a / (b + 1)
try:
line = input('Enter numbers:')
numbers = [int(i) for i in line.split()]
except BaseException:
print('Only use numbers for the input')
Preferred:
try:
x = a / b
except ZeroDivisionError:
x = a / (b + 1)
try:
event_loop.run()
except Exception as exc: # skipcq: PYL-W0703 - Loop can sometimes crash.
sentry.report(exc)
try:
line = input('Enter numbers:')
numbers = [int(i) for i in line.split()]
except ValueError:
print('Only use numbers for the input')