Attribute defined outside
__init__ PYL-W0201
Anti-pattern
Minor
5 months ago
—
3 years old
Attribute 'series' defined outside __init__
796 def get_queryset(self):
797 """get_queryset"""
798 if self.request.user.is_superuser:
799 self.series = get_object_or_404(Series, slug=self.kwargs["slug"]) 800 if self.get_form().is_valid():
801 self.series.soft_delete()
802 else:Attribute 'category' defined outside __init__
734 def get_queryset(self):
735 """get_queryset"""
736 if self.request.user.is_superuser:
737 self.category = get_object_or_404(Category, slug=self.kwargs["slug"]) 738 if self.get_form().is_valid():
739 self.category.soft_delete()
740 else:Attribute 'description' defined outside __init__
546 """get_queryset"""
547 self.tags = get_object_or_404(CustomTag, slug=self.kwargs["slug"])
548 self.title = f"Tag: {self.tags.name}"
549 self.description = f"Posts tagged with {self.tags.name}" 550 return self.model.objects.get_common_queryset(self.request.user).filter(tags=self.tags)
551
552 def get_context_data(self, **kwargs):Attribute 'title' defined outside __init__
545 def get_queryset(self):
546 """get_queryset"""
547 self.tags = get_object_or_404(CustomTag, slug=self.kwargs["slug"])
548 self.title = f"Tag: {self.tags.name}" 549 self.description = f"Posts tagged with {self.tags.name}"
550 return self.model.objects.get_common_queryset(self.request.user).filter(tags=self.tags)
551Attribute 'tags' defined outside __init__
544
545 def get_queryset(self):
546 """get_queryset"""
547 self.tags = get_object_or_404(CustomTag, slug=self.kwargs["slug"]) 548 self.title = f"Tag: {self.tags.name}"
549 self.description = f"Posts tagged with {self.tags.name}"
550 return self.model.objects.get_common_queryset(self.request.user).filter(tags=self.tags)
Description
Defining an instance attribute outside __init__ affects the readability of code. It is expected to find all the attributes an instance may have by reading its __init__ method. If there is a need to initialize attribute via sub-initialization methods, it is recommended to assign attributes to None in the init then call the sub-initialization methods.