JS-0240 · Use shorthand property syntax for object literals

Use shorthand property syntax for object literals JS-0240

Anti-pattern

Minor

a year ago — a year old

Expected property shorthand.

21});
22
23loginBtn.addEventListener('click',()=>{
24    socket.emit('login',{'name' : name,'password' : name});25});
26
27

Expected property shorthand.

public/chat.js

17let getusermsgbtn = document.getElementById('getusermsg');
18
19signupBtn.addEventListener('click',()=>{
20    socket.emit('signup',{'name' : name,'password' : name});21});
22
23loginBtn.addEventListener('click',()=>{

Expected property shorthand.

api/controller/users.js

 61                    }
 62
 63                    if(same){
 64                        User.findOneAndUpdate({name:name},{$set : {socketId : socketId}}) 65                        .then(res=>{
 66                            let result = {
 67                                message : "Auth succesful",

Expected property shorthand.

api/controller/users.js

 48
 49exports.login_user = (name,password,socketId)=>{
 50    return new Promise((resolve,reject)=>{
 51        User.findOne({name:name}) 52            .exec()
 53            .then(user=>{
 54                if(!user){

Expected property shorthand.

api/controller/users.js

 20                    _id : new mongoose.Types.ObjectId,
 21                    name : name,
 22                    password : hash,
 23                    socketId : socketId 24                });
 25   
 26                user.save()

Description

ECMAScript 6 provides a concise form for defining object literal methods and properties. This syntax can make defining complex object literals much cleaner.

Here are a few common examples using the ES5 syntax:

const x = 1, y = 2, z = 3;
// properties
const foo = {
    x: x,
    y: y,
    z: z,
};

// methods
const foo = {
    a: function() {},
    b: function() {}
};

The ES6 equivalent syntax is::

// properties
const foo = {x, y, z};

// methods
const bar = {
    a() { return 1 },
    b() { return 2 }
};

NOTE: The shorthand properties are equivalent to function expressions. Meaning that they do not bind their own this inside their bodies. It is still possible to access properties from the object inside a shorthand member function:

const object = {
    x: 1,
    getX() {
        return this.x // valid
    }
}

Bad Practice

const foo = {
    bar: function () { return 1 }
};

LisahMan / Chat-Application

Bad Practice

Recommended