Require template literals instead of string concatenation JS-0246
Anti-pattern
Minor
a year ago
—
a year old
Unexpected string concatenation.
77
78 let rooms = await userController.get_rooms(data.sendby);
79 for(let r of rooms.rooms){
80 if(r==(data.sendto+data.sendby+"Room")||r==(data.sendby+data.sendto+"Room")){ 81 room = r;
82 break;
83 }Unexpected string concatenation.
77
78 let rooms = await userController.get_rooms(data.sendby);
79 for(let r of rooms.rooms){
80 if(r==(data.sendto+data.sendby+"Room")||r==(data.sendby+data.sendto+"Room")){ 81 room = r;
82 break;
83 }Unexpected string concatenation.
116 let rooms = await userController.get_rooms(data.sendby);
117 let room;
118 for(let r of rooms.rooms){
119 if(r==(data.sendto+data.sendby+"Room")||r==(data.sendby+data.sendto+"Room")){120 room = r;
121 break;
122 }Unexpected string concatenation.
116 let rooms = await userController.get_rooms(data.sendby);
117 let room;
118 for(let r of rooms.rooms){
119 if(r==(data.sendto+data.sendby+"Room")||r==(data.sendby+data.sendto+"Room")){120 room = r;
121 break;
122 }Unexpected string concatenation.
131 let rooms = await userController.get_rooms(data.sendby);
132 let room;
133 for(let r of rooms.rooms){
134 if(r==(data.sendto+data.sendby+"Room")||r==(data.sendby+data.sendto+"Room")){135 room = r;
136 break;
137 }
Description
In ES2015 (ES6), we can use template literals instead of string concatenation.
var str = `Hello, ${name}!`;
Bad Practice
var str = "Hello, " + name + "!";
var str = "Time: " + (12 * 60 * 60 * 1000);
Recommended
var str = "Hello World!";
var str = `Hello, ${name}!`;
var str = `Time: ${12 * 60 * 60 * 1000}`;
var str = "Hello, " + "World!";