Protected member accessed from outside the class PYL-W0212
Bug risk
5 months ago
—
6 months old
Access to a protected member __key of a client class
33
34 def __eq__(self, other) -> bool:
35 if isinstance(other, BasisNode):
36 return self.__key() == other.__key()37 return NotImplemented
Description
Accessing a protected member (a member prefixed with _) of a class from outside that class is not recommended, since the creator of that class did not intend this member to be exposed. If accesing this attribute outside of the class is absolutely needed, refactor it such that it becomes part of the public interface of the class.
Bad practice
class Rectangle(object):
def __init__(self, height, width):
self._height = height
self._width = width
r = Rectangle(4, 8)
area = r._height * r._width
Preferred:
class Rectangle(object):
def __init__(self, height, width):
self._height = height
self._width = width
def area():
return self._height * self._width
r = Rectangle(4, 8)
area = r.area()