Simplify slice expression to sliced value itself CRT-A0016
Anti-pattern
Major
a month ago
—
2 years old
could simplify s[:] to s
79}
80
81func join(s []string) string {
82 return strings.Join(s[:], " ")83}
84
85func swap(a, b int) (int, int) {
Description
If a value is of type slice already, it need not be converted to slice again.
Bad practice
f(s[:]) // s is string
copy(b[:], values...) // b is []byte
Recommended
f(s)
copy(b, values...)